Fix a reace condition caused by one thread calls getMapper method while other threads calling addMapper #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le other threads calling addMapper fix the issue 2890: mybatis#2890
|
Hi @uniquewings , any chance you can test this in your setup and see if it resolves? The other change did a bit more which seemed to be needed, I'm not sure if same is needed here or if this change alone will fix it. I don't see any problem in merging this otherwise though. We do publish to sonatype snapshots in case that helps to pull from there for testing purposes rather than build your own. |
nieqiurong
added a commit
to baomidou/mybatis-plus
that referenced
this pull request
Oct 10, 2023
kazuki43zoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue 2890: #2890